fix: display loading UI after tool execution #1747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1747 +/- ##
=======================================
Coverage 16.75% 16.75%
=======================================
Files 213 213
Lines 20704 20704
Branches 871 871
=======================================
Hits 3468 3468
Misses 17236 17236 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
brandonskiser
approved these changes
May 9, 2025
| terminal::Clear(terminal::ClearType::CurrentLine), | ||
| cursor::MoveToColumn(0), | ||
| cursor::Show, | ||
| cursor::MoveUp(1), |
Contributor
There was a problem hiding this comment.
why is the moveup(1) and clear required here?
Contributor
Author
There was a problem hiding this comment.
to make sure the two "thinking" are on the same line. I think somewhere in this function we printed a newline as a hack for something.
chaynabors
approved these changes
May 13, 2025
brandonskiser
deleted the
1741-ux-display-spinner-immediate-after-tool-completed
branch
This was referenced May 14, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1741